[newlib-cygwin/cygwin-3_4-branch] Cygwin: kill(1): don't print spurious error message

Corinna Vinschen corinna@sourceware.org
Wed Mar 15 21:10:36 GMT 2023


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=e9b1d1ce7f3f20af2860695ab947124219ca6531

commit e9b1d1ce7f3f20af2860695ab947124219ca6531
Author:     Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Wed Mar 15 21:50:32 2023 +0100
Commit:     Corinna Vinschen <corinna@vinschen.de>
CommitDate: Wed Mar 15 22:09:28 2023 +0100

    Cygwin: kill(1): don't print spurious error message
    
    Make kill -V and kill -l exit immediately, thus stopping to
    print "not enough arguments" accidentally.
    
    Fixes: ef48a2cad3704 ("* kill.cc (prog_name) New global variable.")
    Fixes: c49fa762631f9 ("* Makefile.in (kill.exe): Add as a specific target.")
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/release/3.4.7 | 7 +++++--
 winsup/utils/kill.cc        | 2 ++
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/winsup/cygwin/release/3.4.7 b/winsup/cygwin/release/3.4.7
index eba5de47327d..a121d81b62fa 100644
--- a/winsup/cygwin/release/3.4.7
+++ b/winsup/cygwin/release/3.4.7
@@ -1,5 +1,8 @@
 Bug Fixes
 ---------
 
-Fix CPU_SET(3) macro type mismatch by making the macros type-safe.
-Addresses https://cygwin.com/pipermail/cygwin/2023-March/253220.html
+- Fix CPU_SET(3) macro type mismatch by making the macros type-safe.
+  Addresses https://cygwin.com/pipermail/cygwin/2023-March/253220.html
+
+- kill(1): don't print spurious error message.
+  Addresses: https://cygwin.com/pipermail/cygwin/2023-March/253291.html
diff --git a/winsup/utils/kill.cc b/winsup/utils/kill.cc
index 04c9774eb8eb..fc984c0b471e 100644
--- a/winsup/utils/kill.cc
+++ b/winsup/utils/kill.cc
@@ -65,6 +65,7 @@ print_version ()
 	  CYGWIN_VERSION_DLL_MAJOR % 1000,
 	  CYGWIN_VERSION_DLL_MINOR,
 	  strrchr (__DATE__, ' ') + 1);
+  exit (0);
 }
 
 static const char *
@@ -126,6 +127,7 @@ listsig (const char *in_sig)
       else
 	printf ("%d\n", sig);
     }
+  exit (0);
 }
 
 static void


More information about the Cygwin-cvs mailing list