[newlib-cygwin/main] Cygwin: seekdir: don't set errno

Corinna Vinschen corinna@sourceware.org
Tue Jan 23 08:51:01 GMT 2024


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=02572ff089dcefed1e2e25f420be975f1ee7340c

commit 02572ff089dcefed1e2e25f420be975f1ee7340c
Author:     Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Mon Jan 22 19:59:09 2024 +0100
Commit:     Corinna Vinschen <corinna@vinschen.de>
CommitDate: Tue Jan 23 09:49:02 2024 +0100

    Cygwin: seekdir: don't set errno
    
    Commit 3f3bd1010455 ("* Throughout, use __try/__except/__endtry blocks [...]")
    introduced setting EINVAL, marked as "Diagnosis".  The reason
    for this is lost in time and space, but looks very much like
    a debug helper which was supposed to be removed before release.
    It's rather pointless, so remove it.
    
    Fixes: 3f3bd1010455 ("* Throughout, use __try/__except/__endtry blocks [...]")
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/dir.cc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/winsup/cygwin/dir.cc b/winsup/cygwin/dir.cc
index a181ce58c7ec..d67ac02d9159 100644
--- a/winsup/cygwin/dir.cc
+++ b/winsup/cygwin/dir.cc
@@ -235,7 +235,6 @@ seekdir (DIR *dir, long loc)
 	  dir->__flags &= dirent_info_mask;
 	  ((fhandler_base *) dir->__fh)->seekdir (dir, loc);
 	}
-      set_errno (EINVAL);	/* Diagnosis */
     }
   __except (EFAULT) {}
   __endtry


More information about the Cygwin-cvs mailing list