From me@cgf.cx Fri Jun 2 15:06:00 2006 From: me@cgf.cx (Christopher Faylor) Date: Fri, 02 Jun 2006 15:06:00 -0000 Subject: [RFC] Fix expect leaky pipes In-Reply-To: <01b601c682aa$75a1b160$a501a8c0@CAM.ARTIMI.COM> References: <01b601c682aa$75a1b160$a501a8c0@CAM.ARTIMI.COM> Message-ID: <20060602150602.GA1857@trixie.casa.cgf.cx> Ok. I've redone the pty master stuff to use archetypes, in a manner so similar to the slave that I almost think there could be some commonality extracted into tty_common. However, I'm not going to do that yet. It seems to work but it is a big change, although I think there probably is a net loss in code size. I'm going to set an appropriate pre-CVS tag and then check something in. I'd appreciate if you all could check this before I release a snapshot. I've tried my changs with CYGWIN=tty, rxvt, xterm, and openssh but there are bound to be problems given the pervasiveness of this patch. As I mentioned in cygwin-patches, after Dave's investigation led me to think about this, it seems like some of this stuff worked only by coincidence and relied on predictable ways of using pty masters. I hope this patch doesn't have that particular flaw. The one problem that it does have is that it doesn't deal transparently with close-on-exec of pty handles with non-cygwin applications. That was already a problem with the slave part and it is something that can be fixed eventually if it turns out to really present a problem. cgf From pechtcha@cs.nyu.edu Sat Jun 17 18:48:00 2006 From: pechtcha@cs.nyu.edu (Igor Peshansky) Date: Sat, 17 Jun 2006 18:48:00 -0000 Subject: Cygwin web pages and HTML-Tidy Message-ID: Hi, Sorry if this is the wrong list to discuss this, but I didn't want to air this dirty laundry on the main list. If there is a different forum that's more appropriate for this, please let me know. Someone (Lapo?) ran setup.html through HTML-Tidy. Well, first off, that changed the file mode to XHTML (which is a good thing, IMO), but also inlined the content of the (which is a bad thing). Unfortunately, leaving the #include in makes for ill-formed XML, since the closing tag of and the opening tag of were both contained in cygwin-header.html. The only thing that went into the header, technically, was the icon link. I also noticed that other HTML files were invalid, since they would close the tag before the #include, so would be closed twice. Here's my proposal for cleaning it up: 1) Split out the from cygwin-header.html and put it in cygwin-icon.html (which will be #include'd separately). 2) Add a CSS stylesheet to cygwin-header.html. Move all the body attributes (text and link colors) into the CSS stylesheet. Remove the closing tag and the opening tag from cygwin-header.html. Change the individual documents to close and open , keeping the #include within the element. 3) Remove the
sequence of opening tags from cygwin-header.html and require that individual documents define a
with a particular id. That way, we can add stylesheet information to cygwin-header.html to control all of the documents. 4) remove the
sequence of tags from cygwin-footer.html (leaving it empty). I'd rather not get rid of it altogether, since we may conceivably want a footer in the Cygwin webpages at some point. The above set of changes is pretty invasive, so I wanted to run this by the developers before going on with them. Also, I'll post a patch on cygwin-patches for your review before actually checking stuff in. Any comments and suggestions are appreciated. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_ pechtcha@cs.nyu.edu | igor@watson.ibm.com ZZZzz /,`.-'`' -. ;-;;,_ Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! "Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte." "But no -- you are no fool; you call yourself a fool, there's proof enough in that!" -- Rostand, "Cyrano de Bergerac" From me@cgf.cx Sat Jun 17 20:10:00 2006 From: me@cgf.cx (Christopher Faylor) Date: Sat, 17 Jun 2006 20:10:00 -0000 Subject: Cygwin web pages and HTML-Tidy In-Reply-To: References: Message-ID: <20060617201038.GA14444@trixie.casa.cgf.cx> On Sat, Jun 17, 2006 at 02:48:23PM -0400, Igor Peshansky wrote: >Hi, > >Sorry if this is the wrong list to discuss this, but I didn't want to air >this dirty laundry on the main list. If there is a different forum that's >more appropriate for this, please let me know. > >Someone (Lapo?) ran setup.html through HTML-Tidy. Well, first off, that >changed the file mode to XHTML (which is a good thing, IMO), but also >inlined the content of the >(which is a bad thing). Unfortunately, leaving the #include in makes for >ill-formed XML, since the closing tag of and the opening tag of > were both contained in cygwin-header.html. The only thing that >went into the header, technically, was the icon link. > >I also noticed that other HTML files were invalid, since they would close >the tag before the #include, so would be closed twice. > >Here's my proposal for cleaning it up: > >1) Split out the from cygwin-header.html and put it >in cygwin-icon.html (which will be #include'd separately). > >2) Add a CSS stylesheet to cygwin-header.html. Move all the body >attributes (text and link colors) into the CSS stylesheet. Remove the > closing tag and the opening tag from cygwin-header.html. >Change the individual documents to close and open , keeping >the #include within the element. > >3) Remove the
sequence of opening tags from >cygwin-header.html and require that individual documents define a
>with a particular id. That way, we can add stylesheet information to >cygwin-header.html to control all of the documents. > >4) remove the
sequence of tags from cygwin-footer.html >(leaving it empty). I'd rather not get rid of it altogether, since we may >conceivably want a footer in the Cygwin webpages at some point. > >The above set of changes is pretty invasive, so I wanted to run this by >the developers before going on with them. Also, I'll post a patch on >cygwin-patches for your review before actually checking stuff in. I don't really understand the point of these changes other than that the file will now be "proper" html. Since the cygwin web site is under the control of Corinna and myself, this isn't the type of thing that you can just check in, anyway. You definitely will need approval and I, for one, am a fan of the "no one is complaining so why fix it" philosophy in this case, so I'm not really wild about making invasive changes. cgf From pechtcha@cs.nyu.edu Sat Jun 17 20:17:00 2006 From: pechtcha@cs.nyu.edu (Igor Peshansky) Date: Sat, 17 Jun 2006 20:17:00 -0000 Subject: Cygwin web pages and HTML-Tidy In-Reply-To: <20060617201038.GA14444@trixie.casa.cgf.cx> References: <20060617201038.GA14444@trixie.casa.cgf.cx> Message-ID: On Sat, 17 Jun 2006, Christopher Faylor wrote: > On Sat, Jun 17, 2006 at 02:48:23PM -0400, Igor Peshansky wrote: > >Hi, > > > >Sorry if this is the wrong list to discuss this, but I didn't want to air > >this dirty laundry on the main list. If there is a different forum that's > >more appropriate for this, please let me know. > > > >Someone (Lapo?) ran setup.html through HTML-Tidy. Well, first off, that > >changed the file mode to XHTML (which is a good thing, IMO), but also > >inlined the content of the > >(which is a bad thing). Unfortunately, leaving the #include in makes for > >ill-formed XML, since the closing tag of and the opening tag of > > were both contained in cygwin-header.html. The only thing that > >went into the header, technically, was the icon link. > > > >I also noticed that other HTML files were invalid, since they would close > >the tag before the #include, so would be closed twice. > > > >Here's my proposal for cleaning it up: > > > >1) Split out the from cygwin-header.html and put it > >in cygwin-icon.html (which will be #include'd separately). > > > >2) Add a CSS stylesheet to cygwin-header.html. Move all the body > >attributes (text and link colors) into the CSS stylesheet. Remove the > > closing tag and the opening tag from cygwin-header.html. > >Change the individual documents to close and open , keeping > >the #include within the element. > > > >3) Remove the
sequence of opening tags from > >cygwin-header.html and require that individual documents define a
> >with a particular id. That way, we can add stylesheet information to > >cygwin-header.html to control all of the documents. > > > >4) remove the
sequence of tags from cygwin-footer.html > >(leaving it empty). I'd rather not get rid of it altogether, since we may > >conceivably want a footer in the Cygwin webpages at some point. > > > >The above set of changes is pretty invasive, so I wanted to run this by > >the developers before going on with them. Also, I'll post a patch on > >cygwin-patches for your review before actually checking stuff in. > > I don't really understand the point of these changes other than that the > file will now be "proper" html. Since the cygwin web site is under the > control of Corinna and myself, this isn't the type of thing that you can > just check in, anyway. You definitely will need approval and I, for > one, am a fan of the "no one is complaining so why fix it" philosophy > in this case, so I'm not really wild about making invasive changes. My main complaint is that the #include was inlined into setup.html, so now whenever cygwin-header.html (or any other file recursively #included in it) changes, setup.html will not pick up the change (and is larger, to boot). But it would certainly be cleaner (and likely render better) with my changes. Since you didn't complain about the discussion on this list, I'm assuming it's ok. I'll work on a patch (which will probably not be as complex as I made it sound, though it will touch a lot of files), and post it on cygwin-patches when done. We can then decide whether the changes are invasive enough to reject. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_ pechtcha@cs.nyu.edu | igor@watson.ibm.com ZZZzz /,`.-'`' -. ;-;;,_ Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! "Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte." "But no -- you are no fool; you call yourself a fool, there's proof enough in that!" -- Rostand, "Cyrano de Bergerac"